Unified Distributed Storage API implementation #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kurator-dev canceled.
|
Xieql
reviewed
Oct 19, 2023
pkg/apis/fleet/v1alpha1/types.go
Outdated
| // e.g. /var/lib/rook | ||
| // +kubebuilder:validation:Pattern=`^/(\S+)` | ||
| // +optional | ||
| DataDirHostPath string `json:"dataDirHostPath,omitempty"` |
There was a problem hiding this comment.
if it is optional, it should be a pointer type or it hava a built-in nil value(maps or slices).
pkg/apis/fleet/v1alpha1/types.go
Outdated
| // A spec for mon related options | ||
| // +optional | ||
| // +nullable | ||
| Monitor MonSpec `json:"monitor,omitempty"` |
pkg/apis/fleet/v1alpha1/types.go
Outdated
| // A spec for mgr related options | ||
| // +optional | ||
| // +nullable | ||
| Manager MgrSpec `json:"manager,omitempty"` |
There was a problem hiding this comment.
same, check for other properties definition
hzxuzhonghu
reviewed
Oct 20, 2023
pkg/apis/fleet/v1alpha1/types.go
Outdated
| } | ||
|
|
||
| type DistributedStorage struct { | ||
| // The path on the host where config and data can be persisted. Must be set. |
pkg/apis/fleet/v1alpha1/types.go
Outdated
| type StorageDeviceSelection struct { | ||
| // Whether to consume all the storage devices found on a machine | ||
| // indicating whether all devices found on nodes in the cluster should be automatically consumed by OSDs. | ||
| //Not recommended unless you have a very controlled environment where you will not risk formatting of devices with existing data. |
…age updates Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
…age updates. Furthermore modified distributed proposal based on actual API implementation. Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
|
your force push overwrite the origin commit, so reviewers can not get the delta change |
LiZhenCheng9527
changed the title
hzxuzhonghu
reviewed
Oct 24, 2023
pkg/apis/fleet/v1alpha1/types.go
Outdated
|
|
||
| // The placement-related configuration to pass to kubernetes (affinity, node selector, tolerations). | ||
| // +kubebuilder:pruning:PreserveUnknownFields | ||
| // +nullable | ||
| // +optional | ||
| Placement rookv1.PlacementSpec `json:"placement,omitempty"` | ||
| Placement map[string]string `json:"placement,omitempty"` |
There was a problem hiding this comment.
This is not right,
we need such struct
https://github.com/rook/rook/blob/ffaf4a1b3fcea3e0cabb6436328f643ad59407f8/pkg/apis/ceph.rook.io/v1/types.go#L2763C24-L2779
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…age updates
What type of PR is this?
Unified Distributed Storage API Implementation and Dependency Package Follow-Up
What this PR does / why we need it:
Complete API design of storage and go dependency package updates