support pixie vizier #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zirain
force-pushed
the
vizier-helm
branch
2 times, most recently
from
1d33453
to
3ec4803
Compare
hzxuzhonghu
reviewed
Aug 19, 2022
zirain
force-pushed
the
vizier-helm
branch
2 times, most recently
from
0f32f8f
to
2e28fdf
Compare
hzxuzhonghu
reviewed
Aug 22, 2022
hzxuzhonghu
reviewed
Aug 22, 2022
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
hzxuzhonghu
reviewed
Aug 23, 2022
pkg/plugin/pixie/vizier/plugin.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| if err := util.WaitCRDReady(clusterCRDClient, vizierCRDName, p.options.WaitInterval, p.options.WaitTimeout); err != nil { |
There was a problem hiding this comment.
Since it create crds before, why cannot you infer the name from applyCrds. my concern is this could miss other crds
There was a problem hiding this comment.
reasonable, updated.
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@zirain We need a doc for pixie usage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: hejianpeng hejianpeng2@huawei.com
What type of PR is this?
/kind feature
What this PR does / why we need it:
support pixie vizier
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: