Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed an cast-exception #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed an cast-exception #49

wants to merge 1 commit into from

Conversation

iFlyinq
Copy link

@iFlyinq iFlyinq commented May 28, 2021 •
edited

More information about the exception can be found there: https://sentry.io/share/issue/1514e52d4bdf4edc92daf4947bfd84b6/

@iFlyinq
Copy link
Author

iFlyinq commented Jun 12, 2021 •
edited

Is there anyone who can confirm this issue and maybe merge the PR? @kurbatov?

@iFlyinq iFlyinq mentioned this pull request Jun 18, 2021
Open
kurbatov
kurbatov requested changes Jun 19, 2021
View reviewed changes
Copy link
Owner

@kurbatov kurbatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cast is unsafe in the same way the old is. Could you, please, cast it to Number and get an int value from that object?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurbatov kurbatov kurbatov requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iFlyinq @kurbatov