adding ability to select fields, on single resource only for now #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aklkv
force-pushed
the
feature/fields
branch
from
6722fca
to
edd3ff1
Compare
ebryn
reviewed
Feb 26, 2019
src/processors/knex-processor.ts
Outdated
| @@ -51,9 +61,13 @@ export default class KnexProcessor< | |||
| const { id, type } = ref; | |||
| const tableName = this.typeToTableName(type); | |||
| const filters = params ? { id, ...(params.filter || {}) } : { id }; | |||
| const Resource = Object.create(this.resourceFor(type)); | |||
| const resource = Object.create(this.resourceFor(type)); | |||
There was a problem hiding this comment.
why are we using Object.create?
ebryn
reviewed
Feb 26, 2019
src/processors/knex-processor.ts
Outdated
| const resource = Object.create(this.resourceFor(type)); | ||
| const fields = params ? { ...params.fields } : {}; | ||
| const attributes = getAttributes( | ||
| Object.keys(resource.__proto__.attributes), |
There was a problem hiding this comment.
it seems like if we didn't use Object.create we could just be doing something like:
const Resource = this.resourceFor(type);
// ...
Object.keys(Resource.prototype.attributes)
ebryn
approved these changes
Feb 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #25