cannot handle circular flows

[christopherlam]

Hi!
I'm a commiter in https://github.com/Gnucash/gnucash/ and keen to import this nice module for cash flow charts. I hope you wouldn't mind? It'd need to wait for chartJS-3 release first.
One issue: it doesn't seem to sanity check for circular flows?

{ from:"A", to:"B", flow:10 },
{ from:"B", to:"C", flow:10 },
{ from:"C", to:"A", flow:10 }

[kurkle]

No, I would not mind :)

Initial support for circular flows added in just released v0.1.4
The result can be improved, but at least it does not loop forever.

[christopherlam]

Thanks!

[christopherlam]

I think this issue #1 may considered fixed. Looks like chartJS 3 is still in heavy flux, and thus cannot be merged into gnucash until it's out of beta. Therefore a sankey cashflow chart cannot be merged in yet. It may need to wait for 5.0 due sometime in 2022. https://wiki.gnucash.org/wiki/Release_Schedule

[christopherlam]

P.S. WebkitGTK has stopped supporting Windows users. GnuCash uses itfor reports and charts. This means it can use webkit2 on linux, but needs to use webkit1 on mac+windows. Thankfully chartjs runs fairly well on webkit1. I note this project uses some modern javascript, which works well, but we may need to port them to older javascript to be usable in webkit1. So, once chartjs-3 is finalized, and this module is stable, we may need to ask for help occasionally in the future :) Example: Gnucash/gnucash@555a467

//not a native js hacker
//there may be errors in my interpretation as above
@jralls and @gjanssens, lead gnucash devs aren't either