Resolve dataset options (can be scriptable)

[kurkle]

Couple of fixtures fail locally (no spriting)

TODO:

• add tests

[cloudflare-pages]

Deploying with    Cloudflare Pages

Latest commit:	4f2ee49
Status:	✅  Deploy successful!
Preview URL:	https://b737a8c1.chartjs-chart-treemap.pages.dev
Branch Preview URL:	https://options.chartjs-chart-treemap.pages.dev

View logs

[github-actions]

Size Change: -52 B (0%)

Total Size: 19.4 kB

Filename	Size	Change
dist/chartjs-chart-treemap.esm.js	7.09 kB	-23 B (0%)
dist/chartjs-chart-treemap.js	7.32 kB	-22 B (0%)
dist/chartjs-chart-treemap.min.js	5.02 kB	-7 B (0%)

_{compressed-size-action}

[kurkle]

Actually not going to add any tests at this point, because none of the options make sense as scriptable currently.

The caption options are resolved in 2 places (dataset and element), and the first one determines the space while the 2nd one does the drawing. The should be merged somehow. Same story with borderWidth.

So this would need further refactoring.

[stockiNail]

@kurkle I agree. Believe me that I thought several times about that (I don't like it). I was thinking to move the size of the rect calculation after element creation but the buildData should be reviewed completely.

[kurkle]

Agreed about the buildData. I think it should be merged with element creation, and the available child rect calculation moved to element.

Something like

• determine main rect
• parse and create elements on this level
• recurse

So actually quite much the same as the buildData, expect createting elements on the fly.

Label that a breaking change and do it in a major version. Maybe start using data instead of tree

[stockiNail]

So actually quite much the same as the buildData, expect createting elements on the fly.

exactly!

Label that a breaking change and do it in a major version. Maybe start using data instead of tree

I'll open an issue (tomorrow), if you agree, in order to do not forget for version 3.0.

[stockiNail]

Before closing my laptop, I have preferred to submit the issue (I have also created the milestone 3.0.0 and added "breaking change" label because missing).