New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update TryToAnother
parameters in documentation
#35
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! We will review the pull request and get back to you soon.
@Yousef-Majidi I'm so sorry, but I make mistake in my explain, we should use 'try' words only for Thank's |
@kurnakovv Thank you for clarifying. As per your request, I have reverted the change on unnecessary methods. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Yousef-Majidi Good luck to Hacktoberfest course! ;)
P.S. your changes will be in v2.1.1 on nuget FYI
src/EnumConverter/EnumConverter.cs
Outdated
/// <typeparam name="TAnotherEnum">Enum that we want try to get after convert.</typeparam> | ||
/// <param name="enumValue">Input enum we want try to convert to <typeparamref name="TAnotherEnum"/>.</param> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete this changes
src/EnumConverter/EnumConverter.cs
Outdated
/// <typeparam name="TAnotherEnum">Enum that we want try to get after convert.</typeparam> | ||
/// <param name="enumValue">Input enum we want try to convert to <typeparamref name="TAnotherEnum"/>.</param> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete this changes
src/EnumConverter/EnumConverter.cs
Outdated
/// <typeparam name="TAnotherEnum">Enum that we want try to get after convert.</typeparam> | ||
/// <param name="enumValue">Input enum we want try to convert to <typeparamref name="TAnotherEnum"/>.</param> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete this changes
src/EnumConverter/EnumConverter.cs
Outdated
/// <typeparam name="TAnotherEnum">Enum that we want try to get after convert.</typeparam> | ||
/// <param name="enumValue">Input enum we want try to convert to <typeparamref name="TAnotherEnum"/>.</param> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete this changes
Hi @kurnakovv. Thank you for merging the PR. I just have one last favor to ask for if I may. Could you please add the flag I appreciate that you added it to the original issue, and I really appreciate if you could add it to this PR as well. Thank you again : ) |
@Yousef-Majidi Oh yeah, sorry, i forgot this, done :) |
This fixes #33.
I added the word
try
to the the following sentences, anywhere that they appeared in the documentation:Let me know if I missed anything.
Also, if you could add the label
hacktoberfest-accepted
to this PR, I would greatly appreciate it :)