Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update TryToAnother parameters in documentation #35

Merged
merged 2 commits into from Oct 4, 2023

Conversation

Yousef-Majidi
Copy link
Contributor

@Yousef-Majidi Yousef-Majidi commented Oct 4, 2023

This fixes #33.

I added the word try to the the following sentences, anywhere that they appeared in the documentation:

  • "Enum that we want try to get after convert."
  • "Input enum we want try to convert to ."

Let me know if I missed anything.

Also, if you could add the label hacktoberfest-accepted to this PR, I would greatly appreciate it :)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! We will review the pull request and get back to you soon.

@kurnakovv
Copy link
Owner

kurnakovv commented Oct 4, 2023

@Yousef-Majidi I'm so sorry, but I make mistake in my explain, we should use 'try' words only for TryToAnother method. Please, can you delete invalid lines (i pointed it)

Thank's

@Yousef-Majidi
Copy link
Contributor Author

@kurnakovv Thank you for clarifying.

As per your request, I have reverted the change on unnecessary methods.
Thank you.

Copy link
Owner

@kurnakovv kurnakovv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yousef-Majidi Good luck to Hacktoberfest course! ;)

P.S. your changes will be in v2.1.1 on nuget FYI

Comment on lines 13 to 14
/// <typeparam name="TAnotherEnum">Enum that we want try to get after convert.</typeparam>
/// <param name="enumValue">Input enum we want try to convert to <typeparamref name="TAnotherEnum"/>.</param>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this changes

Comment on lines 30 to 31
/// <typeparam name="TAnotherEnum">Enum that we want try to get after convert.</typeparam>
/// <param name="enumValue">Input enum we want try to convert to <typeparamref name="TAnotherEnum"/>.</param>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this changes

Comment on lines 76 to 77
/// <typeparam name="TAnotherEnum">Enum that we want try to get after convert.</typeparam>
/// <param name="enumValue">Input enum we want try to convert to <typeparamref name="TAnotherEnum"/>.</param>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this changes

Comment on lines 89 to 90
/// <typeparam name="TAnotherEnum">Enum that we want try to get after convert.</typeparam>
/// <param name="enumValue">Input enum we want try to convert to <typeparamref name="TAnotherEnum"/>.</param>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this changes

@kurnakovv kurnakovv merged commit e5b0f4b into kurnakovv:main Oct 4, 2023
6 of 7 checks passed
@Yousef-Majidi
Copy link
Contributor Author

Hi @kurnakovv. Thank you for merging the PR.

I just have one last favor to ask for if I may. Could you please add the flag hacktoberfest-accepted to this PR as well, please?

I appreciate that you added it to the original issue, and I really appreciate if you could add it to this PR as well.

Thank you again : )

@kurnakovv
Copy link
Owner

kurnakovv commented Oct 6, 2023

@Yousef-Majidi Oh yeah, sorry, i forgot this, done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix TryToAnother parameters documentation
2 participants