fix: re-enable the Eth network partitioning test on CircleCi #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adschwartz
pushed a commit
that referenced
this pull request
May 10, 2023
We are removing the Ethereum network partitioning test since it's causing test failures and we don't believe it's worth the investment at this time to maintain it. [More context here](#138)
|
Closing this PR because the network partitioning feature was removed from Kurtosis on this PR: kurtosis-tech/kurtosis#1038 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the
Ethereum network partitioning testis disabled on CircleCi because this is failing.You can see the current fails here: https://app.circleci.com/pipelines/github/kurtosis-tech/awesome-kurtosis/693/workflows/dc30cfed-08fc-4306-b313-7a9f9b996c85/jobs/2580 it started in Kurtosis v0.75.9 were we change a piece of code related to the network IP address creations, we are not sure but it seems that this change affected the network partition healing face on this test.
There is an open PR in the Kurtosis mono repo which reverts the change but we won't' merge this change because it will affect the AutoGPT package that is getting traction now (you can get more context about this modification and why this affected the AutoGPT package here )
Solution:
1- remove the test because the network partitioning feature is no longer needed and will be deprecated
2- investigate what is the root cause of the problem that affects partition healing, first clue: make sure to check that the partition is merged again by doing some pings from one client to another client in the other subnetwork. Once the problem is found, it should be fixed, and then release a new version of Kurtosis, bump the dependency here, and enable the test again.
More context:
The discussion about the problem
I created an Ethereum network package fork with a previous version of this package if someone what to import it to test