fix: Check if a local engine is running before switching to a remote context and let the user know what to do #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentluce
changed the title
adschwartz
approved these changes
Jul 27, 2023
adschwartz
reviewed
Jul 27, 2023
h4ck3rk3y
added a commit
that referenced
this pull request
Jul 28, 2023
🤖 I have created a release *beep* *boop* --- ## [0.80.21](0.80.20...0.80.21) (2023-07-28) ### Bug Fixes * Check if a local engine is running before switching to a remote context and let the user know what to do ([#1011](#1011)) ([141247f](141247f)) * fix cpu calculation by getting pre cpu stat ([52a191e](52a191e)) * Implement GetEngineLogs in Kubernete backend ([#1005](#1005)) ([3d0a3e2](3d0a3e2)) * Log streaming was timing out on docker ([#999](#999)) ([d3b6c43](d3b6c43)) * make continuity test work ([#1016](#1016)) ([c430db2](c430db2)) * make resource fetching a parallel operation ([#1012](#1012)) ([52a191e](52a191e)) * only ask for emails on interactive terminals ([#1018](#1018)) ([1bdac73](1bdac73)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: h4ck3rk3y <h4ck3rk3y@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Tell the user if a local engine is running and he is trying to switch to a remote context since it would conflict with the forwarded remote engine port. Move the engine port forwarding from the start of the context switch to after the engine is started so we don't forward too early.
Is this change user facing?
YES