feat: make kurtosis service logs pull from persistent volume #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedim52
force-pushed
the
tedi/service-logs
branch
from
9dfad8e
to
75e35ab
Compare
tedim52
force-pushed
the
tedi/service-logs
branch
from
9a430a8
to
3c10ee8
Compare
tedim52
commented
Aug 18, 2023
...kend_impls/docker/docker_kurtosis_backend/docker_kurtosis_backend_api_container_functions.go
Show resolved
Hide resolved
Deploying with
|
| Latest commit: |
d8c85e7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://04435f74.kurtosis-docs.pages.dev |
| Branch Preview URL: | https://tedi-service-logs.kurtosis-docs.pages.dev |
gbouv
approved these changes
Aug 21, 2023
...lib/lib/backend_impls/docker/object_attributes_provider/docker_label_key/docker_label_key.go
Show resolved
Hide resolved
...ls/docker/docker_kurtosis_backend/logs_aggregator_functions/implementations/vector/consts.go
Show resolved
Hide resolved
...ized_logs/client_implementations/persistent_volume/persistent_volume_logs_database_client.go
Show resolved
Hide resolved
...logs/client_implementations/persistent_volume/persistent_volume_logs_database_client_test.go
Outdated
Show resolved
Hide resolved
internal_testsuites/golang/testsuite/persisted_logs_test/persisted_logs_test.go
Show resolved
Hide resolved
tedim52
force-pushed
the
tedi/service-logs
branch
from
92b47ef
to
350fadd
Compare
tedim52
force-pushed
the
tedi/service-logs
branch
from
350fadd
to
caf07a4
Compare
gbouv
pushed a commit
that referenced
this pull request
Aug 22, 2023
🤖 I have created a release *beep* *boop* --- ## [0.82.0](0.81.9...0.82.0) (2023-08-22) ### ⚠ BREAKING CHANGES * Portal remote endpoints and forward port wait until ready option ([#1124](#1124)) ### Features * Add possibility to pass env vars to enclave ([#1134](#1134)) ([9889e6f](9889e6f)) * added connect-go for engine ([#879](#879)) ([8c0121c](8c0121c)) * make kurtosis service logs pull from persistent volume ([#1121](#1121)) ([8e52a24](8e52a24)) * Portal remote endpoints and forward port wait until ready option ([#1124](#1124)) ([f4e3e77](f4e3e77)) * propogated bridge network ip address ([#1135](#1135)) ([04ed723](04ed723)) ### Bug Fixes * More flexible context config unmarshaller ([#1132](#1132)) ([7892bda](7892bda)) * Use portal deps from the main branch - Part 2 ([#1138](#1138)) ([f0a2353](f0a2353)) * Use portal deps from the main branch ([#1136](#1136)) ([b9da525](b9da525)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR is the v1 for the centralized logging architecture over Docker. Specifically, it makes the following changes:
LogsAggregatorandengineto this volumeLogsAggregatorto store logs in volumeengineto retrieve logs from volume viaPersistentVolumeLogsDatabaseClientIs this change user facing?
NO
References (if applicable):
#1071