feat: make paths relative to support embedding in other contexts #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoporoli
approved these changes
Aug 24, 2023
adschwartz
pushed a commit
that referenced
this pull request
Aug 24, 2023
🤖 I have created a release *beep* *boop* --- ## [0.82.2](0.82.1...0.82.2) (2023-08-24) ### Features * make paths relative to support embedding in other contexts ([#1151](#1151)) ([74fbe53](74fbe53)) ### Bug Fixes * lower calls to backend by doing get all services more efficiently ([#1143](#1143)) ([a2c0dcc](a2c0dcc)), closes [#1074](#1074) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Loading the Enclave Manager through a proxy doesn't work since all links are absolute and refer to the root of the url. We need it to be relative to where it was loaded.
Is this change user facing?
NO