fix: Point to the engine restart command as part of the context switch failure remediation to not conflict with lower level commands #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lure remediation to not conflict with lower level commands - Replace stop/start engine with restart.
laurentluce
commented
Aug 29, 2023
laurentluce
commented
Aug 29, 2023
adschwartz
approved these changes
Aug 29, 2023
There was a problem hiding this comment.
This is a great catch @laurentluce. It helps to tell the user to use engine restart, but it's still odd to me that engine restart != engine stop && engine start. I feel like we should fix that bit at some point.
This change is unrelated to the main change. I did this one as a cleanup task. |
Peeeekay
pushed a commit
that referenced
this pull request
Aug 30, 2023
🤖 I have created a release *beep* *boop* --- ## [0.82.15](0.82.14...0.82.15) (2023-08-30) ### Bug Fixes * cluster set doesnt get into a weird state of no cluster being set ([#1055](#1055)) ([c647035](c647035)) * enclave name validation to support valid DNS-1035 label rules ([#1204](#1204)) ([74845a8](74845a8)) * make test enclave creation support DNS label rules ([#1202](#1202)) ([df61ecc](df61ecc)) * Point to the engine restart command as part of the context switch failure remediation to not conflict with lower level commands ([#1191](#1191)) ([f83e513](f83e513)) * removed the flaky tests ([#1205](#1205)) ([b990674](b990674)) * this pr fixes the search issue. ([#1201](#1201)) ([2a17b1b](2a17b1b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The engine remediation command in the context switch logic sometimes conflicts with lower level engine remediation commands. One example is when the running engine version does not match the CLI version, the user is presented with two remediation commands:
engine startandengine restart. Only the second one remediates the issue. This change updates the engine remediation command in the context switch logic to beengine restartwhich also works if the engine is not running.Note that we don't want to restart the engine automatically when there is a version mismatch because different users could be using different CLI versions and we don't want to end up in a tug of war match.
Is this change user facing?
YES