feat: enable retrieving logs from services in stopped enclaves #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peeeekay
approved these changes
Aug 31, 2023
gbouv
pushed a commit
that referenced
this pull request
Sep 1, 2023
🤖 I have created a release *beep* *boop* --- ## [0.82.17](0.82.16...0.82.17) (2023-09-01) ### Features * enable retrieving logs from services in stopped enclaves ([#1213](#1213)) ([83c269c](83c269c)) * Pass enclave name to Starlark global `kurtosis` module ([#1216](#1216)) ([c5f2c97](c5f2c97)) * Persist runtime value store ([#1170](#1170)) ([cfec9b3](cfec9b3)) * track the analytics toggle event ([#1217](#1217)) ([10c461f](10c461f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
tedim52
added a commit
that referenced
this pull request
Oct 6, 2023
## Description: Due to this [PR](#1213), the logs aggregator stores duplicate log files which causes log storage to grow quickly. This change prevents storing duplicate logs by periodically replacing the duplicate log files with symlinks to a single log file. This allows logs to still be retrievable from stopped enclaves using any service identifier without increasing log storage. Also includes a small refactor to use a better supported pkg (`spf13/afero`) to mock the filesystem that cleans up logging unit tests quite a bit. ## Is this change user facing? NO ## References: #1213 #1394 #1459
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Enables retrieving logs in stopped enclaves.
Context:
Logs were stored
/enclave uuid/service uuid.json. When an enclave is running, id logic translates shortened uuids and service names toservice uuid. However when an enclave is stopped, the service identifier information is lost and that translation isn't possible so users wouldn't be able to retrieve logs from a stopped enclave via the service name or shortened uuid.Adjusting the id logic would've required a larger refactor to persist service id info beyond enclave lifecycle.
This PR implements a cheaper solution - store logs
/enclave uuid/service uuid.json, as well as/enclave uuid/service name.jsonand/enclave uuid/service short uuid.json, with the tradeoff of tripling log storage. I've added a TODO to develop a better solution.Is this change user facing?
YES