feat: Add starlark.Value serializer/deserializer for enclave persistence #1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbouv
force-pushed
the
gbouv/starlark-value-serde
branch
from
fa3b3f5
to
2fe9381
Compare
gbouv
force-pushed
the
gbouv/starlark-value-serde
branch
from
2fe9381
to
22dd20d
Compare
leoporoli
reviewed
Sep 4, 2023
...r/startosis_engine/kurtosis_starlark_framework/test_engine/starlark_framework_engine_test.go
Show resolved
Hide resolved
leoporoli
reviewed
Sep 4, 2023
core/server/api_container/server/startosis_engine/starlark_value_serde.go
Show resolved
Hide resolved
leoporoli
approved these changes
Sep 4, 2023
victorcolombo
pushed a commit
that referenced
this pull request
Sep 5, 2023
🤖 I have created a release *beep* *boop* --- ## [0.82.19](0.82.18...0.82.19) (2023-09-05) ### Features * Add starlark.Value serializer/deserializer for enclave persistence ([#1229](#1229)) ([45b9330](45b9330)) ### Bug Fixes * close engine server which is important for triggering the idle enclaves remotion process ([#1219](#1219)) ([912e855](912e855)) * disabled time.now() ([#1231](#1231)) ([26e8d40](26e8d40)) * Does not delete runtime value during idepotent runs ([#1232](#1232)) ([a06c247](a06c247)) * fix a sneaky segmentation fault where we were propagating a nil error ([#1222](#1222)) ([666f4ee](666f4ee)) * fix a typo in recipe result repository ([#1224](#1224)) ([94a4b8b](94a4b8b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
For idempotent runs, we need to store for each instruction that was run the result object of this instruction, which can be any starlark.Value. This serde mechanism relies the Starlark code itself to serialize the value, and runs a mini-interpretation step to deserialize it.
Is this change user facing?
NO
References (if applicable):