fix: handle default string value properly #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peeeekay
force-pushed
the
pk/package_catalog_bug
branch
from
5e5b801
to
92ee8b9
Compare
adschwartz
reviewed
Sep 6, 2023
adschwartz
reviewed
Sep 6, 2023
adschwartz
reviewed
Sep 6, 2023
adschwartz
suggested changes
Sep 6, 2023
@adschwartz is it cool if i do that in another PR because it would require me to add some plumbing - but this can unblock nam. |
adschwartz
reviewed
Sep 6, 2023
adschwartz
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
@Peeeekay Unblocking you but I think we should follow up with some increased quality and a unit test if possible.
Peeeekay
pushed a commit
that referenced
this pull request
Sep 6, 2023
🤖 I have created a release *beep* *boop* --- ## [0.82.20](0.82.19...0.82.20) (2023-09-06) ### Bug Fixes * handle default string value properly ([#1243](#1243)) ([6e49059](6e49059)) * Runtime values created by `add_services` were incorrect in the case of a skipped instruction ([#1239](#1239)) ([3412486](3412486)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug found recently where the default value in the starlark package was being overwritten by the "" passed by the frontend.