refactor!: rename assert to verify #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h4ck3rk3y
force-pushed
the
gyani/lint
branch
from
6794b8b
to
9ab031a
Compare
h4ck3rk3y
changed the title
|
@leoporoli if you can review this before Monday then I can get it out in the next release cycle |
Deploying with
|
| Latest commit: |
1361842
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cb99ad63.kurtosis-docs.pages.dev |
| Branch Preview URL: | https://gyani-lint.kurtosis-docs.pages.dev |
leoporoli
approved these changes
Sep 14, 2023
This was referenced Sep 18, 2023
h4ck3rk3y
pushed a commit
that referenced
this pull request
Sep 18, 2023
🤖 I have created a release *beep* *boop* --- ## [0.83.0](0.82.24...0.83.0) (2023-09-18) ### ⚠ BREAKING CHANGES * rename assert to verify ([#1295](#1295)) * print a downloaded container images summary after pulling images from remote or locally ([#1315](#1315)) ### Features * Clean CLI command now removes unsued Kurtosis images ([#1314](#1314)) ([a924f4a](a924f4a)), closes [#1131](#1131) * print a downloaded container images summary after pulling images from remote or locally ([#1315](#1315)) ([b822870](b822870)), closes [#1292](#1292) ### Code Refactoring * rename assert to verify ([#1295](#1295)) ([651df40](651df40)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
h4ck3rk3y
added a commit
to kurtosis-tech/kurtosis-portal
that referenced
this pull request
Sep 18, 2023
This requires kurtosis-tech/kurtosis#1295 to be released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We have renamed
plan.asserttoplan.verify. Users are encouraged to replace any usage ofplan.assertin their Starlark withplan.verifyIs this change user facing?
YES/NO
References (if applicable):