feat: CLI service inspect command #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
ca1aeb6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2fdf7fe6.kurtosis-docs.pages.dev |
| Branch Preview URL: | https://laurent-service-inspect.kurtosis-docs.pages.dev |
laurentluce
commented
Sep 18, 2023
laurentluce
commented
Sep 18, 2023
laurentluce
commented
Sep 18, 2023
laurentluce
commented
Sep 18, 2023
cli/cli/helpers/service_status_stringifier/service_status_stringifier.go
Show resolved
Hide resolved
laurentluce
commented
Sep 18, 2023
laurentluce
commented
Sep 18, 2023
container-engine-lib/lib/backend_impls/docker/docker_manager/docker_manager.go
Show resolved
Hide resolved
laurentluce
commented
Sep 18, 2023
container-engine-lib/lib/backend_impls/docker/docker_manager/docker_manager.go
Show resolved
Hide resolved
laurentluce
commented
Sep 18, 2023
...ib/lib/backend_impls/kubernetes/kubernetes_kurtosis_backend/shared_helpers/shared_helpers.go
Show resolved
Hide resolved
laurentluce
commented
Sep 18, 2023
container-engine-lib/lib/backend_interface/objects/container/container.go
Show resolved
Hide resolved
adschwartz
reviewed
Sep 18, 2023
...ib/lib/backend_impls/kubernetes/kubernetes_kurtosis_backend/shared_helpers/shared_helpers.go
Show resolved
Hide resolved
adschwartz
reviewed
Sep 18, 2023
...ubernetes_kurtosis_backend/user_services_functions/run_user_service_exec_command_streamed.go
Show resolved
Hide resolved
adschwartz
approved these changes
Sep 18, 2023
h4ck3rk3y
added a commit
that referenced
this pull request
Sep 19, 2023
🤖 I have created a release *beep* *boop* --- ## [0.83.3](0.83.2...0.83.3) (2023-09-19) ### Features * CLI service inspect command ([#1323](#1323)) ([ec018b9](ec018b9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com> Co-authored-by: Gyanendra Mishra <anomaly.the@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
There is no CLI option today to get the user service container image, entrypoint args, cmd args and env vars. The user has to use the Docker or K8S CLI to access those information. A new
service inspectCLI command is added.The
GetServicesresponse object is updated to include a container object containing its status, image name, entrypoint and cmd args, and env vars. The path from the backend to the response object is updated.Is this change user facing?
YES