feat: implement -n X and -a flags #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedim52
force-pushed
the
tedi/tail-logs
branch
from
c14d9bc
to
76135fe
Compare
tedim52
force-pushed
the
tedi/tail-logs
branch
from
75676f4
to
a05d247
Compare
Peeeekay
reviewed
Sep 21, 2023
...ient_implementations/persistent_volume/stream_logs_strategy/per_week_stream_logs_strategy.go
Show resolved
Hide resolved
|
@tedim52 Looks good to me. I am trusting the tests |
Peeeekay
approved these changes
Sep 21, 2023
adschwartz
pushed a commit
that referenced
this pull request
Sep 25, 2023
🤖 I have created a release *beep* *boop* --- ## [0.83.6](0.83.5...0.83.6) (2023-09-22) ### Features * implement -n X and -a flags ([#1341](#1341)) ([2c6880c](2c6880c)) ### Bug Fixes * enclave manager ui was reading the wrong type fields ([#1367](#1367)) ([0bae141](0bae141)) * Manually locate docker socket ([#1362](#1362)) ([7fe4956](7fe4956)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
|
@tedim52 - i cannot see the docs for this, do you mind adding? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds the
-aand-nflags tokurtosis service logs.-aflag returns all logs of a service-n XreturnsXnumber of log lines-aused with-n Xwill return all the logs. Both flags can be used in combination with-f.... service logswithout any flags by default returns 200 log lines.Is this change user facing?
YES