New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: return the production enclave information if present via GetEnclaves API #1395
Conversation
...ib/backend_impls/docker/docker_kurtosis_backend/docker_kurtosis_backend_enclave_functions.go
Outdated
Show resolved
Hide resolved
...ib/backend_impls/docker/docker_kurtosis_backend/docker_kurtosis_backend_enclave_functions.go
Outdated
Show resolved
Hide resolved
...ib/backend_impls/docker/docker_kurtosis_backend/docker_kurtosis_backend_enclave_functions.go
Outdated
Show resolved
Hide resolved
...ib/backend_impls/docker/docker_kurtosis_backend/docker_kurtosis_backend_enclave_functions.go
Outdated
Show resolved
Hide resolved
a801bd3
to
bb897d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the only suggestion that I have is that it could be implemented by storing the enclave production mode
value in the Docker labels and retrieving it by getting the APIC container's labels as we do for the other enclave information, like ports, enclaveID, etc. In order to normalize how the enclave info is stored and retrieved.
But it can be refactored later if this feat needs to be released soon.
Yes; make sense. I want to confirm with @victorcolombo about that as currently we store it as env variable and if it's ok to store it in label as well. I am not familiar if it cause some unintentional bugs. |
🤖 I have created a release *beep* *boop* --- ## [0.83.10](0.83.9...0.83.10) (2023-09-27) ### Features * disable scrollbar, remove line highlighting, set background color ([#1408](#1408)) ([1ffdf10](1ffdf10)), closes [#1391](#1391) * return the production enclave information if present via GetEnclaves API ([#1395](#1395)) ([ef22820](ef22820)) ### Bug Fixes * add scrollbar ([#1400](#1400)) ([40aba1d](40aba1d)), closes [#1390](#1390) * bring back args ([#1397](#1397)) ([3e1c318](3e1c318)) * text off center ([#1407](#1407)) ([d845764](d845764)), closes [#1406](#1406) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com> Co-authored-by: Tedi Mitiku <tedi.m52@gmail.com> Co-authored-by: tedim52 <tedim52@users.noreply.github.com>
This PR returns whether the enclave is running in production mode via GetEnclaves() api.
Sample Response for test enclave:
{
"enclaveUuid": "1a8396beea6a464d83ee27900eea012e",
"name": "vibrant-volcano",
"shortenedUuid": "1a8396beea6a",
"containersStatus": "EnclaveContainersStatus_RUNNING",
"apiContainerStatus": "EnclaveAPIContainerStatus_RUNNING",
...
}
Sample Response for prod enclave:
{
"enclaveUuid": "1a8396beea6a464d83ee27900eea012e",
"name": "vibrant-volcano",
"shortenedUuid": "1a8396beea6a",
"containersStatus": "EnclaveContainersStatus_RUNNING",
"apiContainerStatus": "EnclaveAPIContainerStatus_RUNNING",
"mode":"PRODUCTION"
}