Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Edit Enclave #1478

Merged
merged 37 commits into from Oct 5, 2023
Merged

feat: Edit Enclave #1478

merged 37 commits into from Oct 5, 2023

Conversation

adschwartz
Copy link
Contributor

Description:

With this change the user can click to edit a running enclave, change the configuration of the enclave (package), click Run and the enclave will update idempotently (using idempotent runs).

Is this change user facing?

YES

References (if applicable):

# Conflicts:
#	api/typescript/package-lock.json
#	engine/frontend/package-lock.json
# Conflicts:
#	core/server/api_container/server/api_container_service.go
@adschwartz adschwartz enabled auto-merge (squash) October 5, 2023 16:30
Copy link
Contributor

@tedim52 tedim52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - sick feature

@adschwartz adschwartz merged commit d11736a into main Oct 5, 2023
32 checks passed
@adschwartz adschwartz deleted the anders/edit-enclave branch October 5, 2023 16:36
adschwartz pushed a commit that referenced this pull request Oct 5, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.84.2](0.84.1...0.84.2)
(2023-10-05)


### Features

* Edit Enclave
([#1478](#1478))
([d11736a](d11736a))
* Get Starlark Run APIC endpoint
([#1455](#1455))
([503cb8d](503cb8d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants