fix: make vector use ISO week time #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galenmarchetti
approved these changes
Oct 8, 2023
h4ck3rk3y
added a commit
that referenced
this pull request
Oct 9, 2023
🤖 I have created a release *beep* *boop* --- ## [0.84.3](0.84.2...0.84.3) (2023-10-09) ### Features * regular replace package dependency and replace package with no-main-branch ([#1481](#1481)) ([bec49ac](bec49ac)) * remove logs on enclave rm and clean -a ([#1489](#1489)) ([9ea344e](9ea344e)) ### Bug Fixes * Add new line while inspecting file contents ([#1477](#1477)) ([545aa53](545aa53)) * improve absolute locator checks ([#1498](#1498)) ([cda001d](cda001d)) * kurtosis web cmd work for remote context ([#1486](#1486)) ([8d8634c](8d8634c)) * make vector use ISO week time ([#1497](#1497)) ([e6d1f5e](e6d1f5e)) * replace duplicate log files with symlinks ([#1472](#1472)) ([57da901](57da901)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: h4ck3rk3y <h4ck3rk3y@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
There was a bug where the
LogsAggregatorwas using a different time format for week than theLogsDatabaseClient.In special cases (like today), the
LogsAggregatorandLogsDatabaseClientdisagreed about what week it was. The former said it was week 41 and the latter said it was week 40. This disagreement prevented users from being able to pull logs today.This change makes them agree from now on by making them use the same week format : )
Is this change user facing?
YES (no more bug)