Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve description of the image-download flag #1660

Merged
merged 4 commits into from Oct 31, 2023

Conversation

lostbean
Copy link
Contributor

Description:

Improve description of the image-download flag in both CLI help and docs.

Is this change user facing?

YES

References (if applicable):

Copy link
Contributor

@leeederek leeederek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposed some suggestions - feel free to merge

cli/cli/commands/run/run.go Outdated Show resolved Hide resolved
docs/docs/cli-reference/run.md Outdated Show resolved Hide resolved
Copy link

cloudflare-pages bot commented Oct 31, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7f5846f
Status: ✅  Deploy successful!
Preview URL: https://056d7739.kurtosis-docs.pages.dev
Branch Preview URL: https://edgar-hotfix-image-download.kurtosis-docs.pages.dev

View logs

@leeederek leeederek added this pull request to the merge queue Oct 31, 2023
Merged via the queue into main with commit 230b4d0 Oct 31, 2023
34 checks passed
@leeederek leeederek deleted the edgar/hotfix_image_download_docs branch October 31, 2023 22:00
github-merge-queue bot pushed a commit that referenced this pull request Nov 3, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.85.3](0.85.2...0.85.3)
(2023-11-03)


### Features

* add timestamps to log lines
([#1675](#1675))
([2eeb643](2eeb643))
* new emui design tweaks
([#1670](#1670))
([f172cd7](f172cd7))
* rename all JSON to YAML
([#1650](#1650))
([219ac7a](219ac7a))


### Bug Fixes

* actually create production enclaves
([#1682](#1682))
([8987212](8987212))
* Improve description of the image-download flag
([#1660](#1660))
([230b4d0](230b4d0))
* mention URL JSON path in kurtosis run -h
([#1676](#1676))
([c8c0ec8](c8c0ec8))
* prefix warning to the image validation
([#1673](#1673))
([88147fb](88147fb))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants