feat: add timestamps to log lines #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adschwartz
reviewed
Nov 2, 2023
...alized_logs/client_implementations/kurtosis_backend/kurtosis_backend_logs_database_client.go
Outdated
Show resolved
Hide resolved
adschwartz
reviewed
Nov 2, 2023
...alized_logs/client_implementations/kurtosis_backend/kurtosis_backend_logs_database_client.go
Show resolved
Hide resolved
adschwartz
approved these changes
Nov 2, 2023
adschwartz
reviewed
Nov 2, 2023
...implementations/persistent_volume/stream_logs_strategy/per_week_stream_logs_strategy_test.go
Show resolved
Hide resolved
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 3, 2023
🤖 I have created a release *beep* *boop* --- ## [0.85.3](0.85.2...0.85.3) (2023-11-03) ### Features * add timestamps to log lines ([#1675](#1675)) ([2eeb643](2eeb643)) * new emui design tweaks ([#1670](#1670)) ([f172cd7](f172cd7)) * rename all JSON to YAML ([#1650](#1650)) ([219ac7a](219ac7a)) ### Bug Fixes * actually create production enclaves ([#1682](#1682)) ([8987212](8987212)) * Improve description of the image-download flag ([#1660](#1660)) ([230b4d0](230b4d0)) * mention URL JSON path in kurtosis run -h ([#1676](#1676)) ([c8c0ec8](c8c0ec8)) * prefix warning to the image validation ([#1673](#1673)) ([88147fb](88147fb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Attaches timestamps to all log lines to indicate when "kurtosis" logging infrastructure received the log line.
Is this change user facing?
NO