feat: manage parameters and URL #1689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # enclave-manager/web/src/components/enclaves/modals/ConfigureEnclaveModal.tsx
Dartoxian
reviewed
Nov 6, 2023
enclave-manager/web/src/client/enclaveManager/KurtosisClient.ts
Outdated
Show resolved
Hide resolved
enclave-manager/web/src/components/enclaves/configuration/EnclaveConfigurationForm.tsx
Outdated
Show resolved
Hide resolved
Dartoxian
reviewed
Nov 6, 2023
tedim52
approved these changes
Nov 6, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dartoxian
reviewed
Nov 7, 2023
enclave-manager/web/src/client/enclaveManager/KurtosisClientContext.tsx
Outdated
Show resolved
Hide resolved
Dartoxian
reviewed
Nov 7, 2023
done - and added curly |
## Description: This change adds support for showing enclave service logs in the new enclave manager ui. Additionally, this pr contains a partial implementation of the service view ui - full implementation to follow. ### Demo: In this demo `github.com/kurtosis-tech/log-load-package` is used to demonstrate large quantities of logs don't seem to break following. Additionally, my browser has it's locale set to san francisco - so that browser locale dependent timestamps can be demonstrated. https://github.com/kurtosis-tech/kurtosis/assets/4419574/533b5f5a-7fdf-40b1-a6c5-e0b67970811c ## Is this change user facing? YES
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 7, 2023
🤖 I have created a release *beep* *boop* --- ## [0.85.4](0.85.3...0.85.4) (2023-11-07) ### Features * add autocomplete for cluster set command ([#1695](#1695)) ([d36164d](d36164d)) * manage parameters and URL ([#1689](#1689)) ([eafc056](eafc056)) * new em ui enclave logs ([#1696](#1696)) ([788c7bc](788c7bc)) * print Made with Kurtosis at the end of a run ([#1687](#1687)) ([a08b0b1](a08b0b1)) ### Bug Fixes * correct is_ci value in metrics from APIC ([#1697](#1697)) ([9df62dd](9df62dd)) * kurtosis run considers every nonexistent path to be a URL and fails with a suspicious error ([#1706](#1706)) ([0f7809e](0f7809e)), closes [#1705](#1705) * return the correct yaml parsing error ([#1691](#1691)) ([c6170ec](c6170ec)) * user/instance id values were flipped ([#1698](#1698)) ([901069c](901069c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Changes:
Is this change user facing?
YES