fix: correct is_ci value in metrics from APIC #1697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Screen.Recording.2023-11-06.at.6.42.07.PM.mov@leoporoli demo of the feature that reads from env variables on where engine restart is run |
leoporoli
approved these changes
Nov 6, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 7, 2023
🤖 I have created a release *beep* *boop* --- ## [0.85.4](0.85.3...0.85.4) (2023-11-07) ### Features * add autocomplete for cluster set command ([#1695](#1695)) ([d36164d](d36164d)) * manage parameters and URL ([#1689](#1689)) ([eafc056](eafc056)) * new em ui enclave logs ([#1696](#1696)) ([788c7bc](788c7bc)) * print Made with Kurtosis at the end of a run ([#1687](#1687)) ([a08b0b1](a08b0b1)) ### Bug Fixes * correct is_ci value in metrics from APIC ([#1697](#1697)) ([9df62dd](9df62dd)) * kurtosis run considers every nonexistent path to be a URL and fails with a suspicious error ([#1706](#1706)) ([0f7809e](0f7809e)), closes [#1705](#1705) * return the correct yaml parsing error ([#1691](#1691)) ([c6170ec](c6170ec)) * user/instance id values were flipped ([#1698](#1698)) ([901069c](901069c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Earlier metrics from the APIC wouldn't get the right value for is_ci as they would look for the CI environment(TF_BUILD, CIRCLE_CI...) variables which our docker container wouldn't contain;
Now
So if someone is running in Circle/GitHub actions - wherever the
kurtosis engine restarthappens we get the valid IS_CI value for that CLI