feat: generate enclave manager ui in build process and check prettier #1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dartoxian
force-pushed
the
feat/em-prettier-check
branch
5 times, most recently
from
4636211
to
c5e2ff3
Compare
## Description: This PR corrects the enclave configuration form input to use boolean if a package argument type is boolean - which is enum value 0 and was previously treated as falsy. ### Screenshot of fix  ## Is this change user facing? YES
Dartoxian
force-pushed
the
feat/em-prettier-check
branch
from
217878e
to
3ee6ece
Compare
adschwartz
reviewed
Nov 10, 2023
adschwartz
suggested changes
Nov 10, 2023
There was a problem hiding this comment.
@Dartoxian this looks good. I only have a single comment/question. We can try running it after your review.
adschwartz
approved these changes
Nov 16, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 16, 2023
🤖 I have created a release *beep* *boop* --- ## [0.85.24](0.85.23...0.85.24) (2023-11-16) ### Features * generate enclave manager ui in build process and check prettier ([#1717](#1717)) ([d6be248](d6be248)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pr includes the new enclave manager in the build process - specifically in the
enginebuild process. This removes the need to commit the built emui to the codebase.Additionally
yarn prettieris added as a build step to the emui, which will fail the build if prettier has not been run (as is currently the case in main).This change also includes a fix to all linting warnings, so that there are no warnings in the production build.
Is this change user facing?
NO
References (if applicable):