fix: emui optimistic data loading #1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description: * Support subpackages * Increase size of dict and list input form components ## Is this change user facing? YES
adschwartz
approved these changes
Nov 13, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 13, 2023
🤖 I have created a release *beep* *boop* --- ## [0.85.19](0.85.18...0.85.19) (2023-11-13) ### Features * add enclave's flags info in the `kurtosis enclave inspect` CLI command ([#1751](#1751)) ([35bad59](35bad59)), closes [#1363](#1363) ### Bug Fixes * emui optimistic data loading ([#1771](#1771)) ([f105fa0](f105fa0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR removes the use of react-router data loaders and actions, instead managing this behaviour inside a new
EMUIAppContext. This allows us to implement optimistic ui patterns - letting us load the initial enclave list as data become available, and updating it without a backend fetch (on create/delete operations).Also this PR fixes the issue identified with boolean values not being persisted - in fact the values were read and persisted, just not rendered correctly on subsequent load.
Demo
As this is quite a substantial change, this demo quickly goes over the majority of the data interactions in the emui.
optimistic.mp4
Is this change user facing?
YES