Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show usage text when CLI cmd fails because of missing a required argument #1774

Merged
merged 3 commits into from Nov 14, 2023

Conversation

leoporoli
Copy link
Contributor

Description:

show usage text when CLI cmd fails because of missing a required argument

Is this change user facing?

YES

References (if applicable):

fix #1576

Message example:
image

Copy link
Contributor

@omar711 omar711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @leoporoli ; gave it a test locally too, couldn't spot any issue

@leoporoli leoporoli added this pull request to the merge queue Nov 14, 2023
Merged via the queue into main with commit a7df8cf Nov 14, 2023
33 checks passed
@leoporoli leoporoli deleted the lporoli/ticket-1576 branch November 14, 2023 12:31
github-merge-queue bot pushed a commit that referenced this pull request Nov 14, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.85.21](0.85.20...0.85.21)
(2023-11-14)


### Features

* show usage text when CLI cmd fails because of missing a required
argument
([#1774](#1774))
([a7df8cf](a7df8cf))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI should default to showing help when zero args are provided
2 participants