fix: emui build #1826
Merged
fix: emui build #1826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marked as do not merge as I expect we want to hold off on this until Tuesday. |
adschwartz
reviewed
Jan 8, 2024
adschwartz
approved these changes
Jan 10, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 10, 2024
🤖 I have created a release *beep* *boop* --- ## [0.86.3](0.86.2...0.86.3) (2024-01-10) ### Bug Fixes * emui build ([#1826](#1826)) ([9ebd0df](9ebd0df)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 10, 2024
…docs_changes (#2038) ## Description: By aborting `build_enclave_manager_webapp` with `abort_job_if_only_docs_changes` the abort will always occur if the build runs on `main` (as the diff there between `main` and `HEAD` will always be empty). We need `build_enclave_manager_webapp` to run on `main` so that it can be consumed by the `publish_engine_server_image` task. ## Is this change user facing? NO ## References (if applicable): - #1826 - https://app.circleci.com/pipelines/github/kurtosis-tech/kurtosis/10633/workflows/a50a852d-6570-48ad-9e65-22e9af074a4e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR brings the emui into the ci build/release process. It is a reversion of last nights #1813.
Yesterday the build/release change for emui was abandoned because after several attempts the publish step was not working. In 4ed9328 I have demonstrated that this pr works by:
bgazzard-*tagsbgazzard-0.0.1(which I have now deleted) to trigger thepublishworkflowbuild_enclave_manager_webappjob is now successfully run as a dependency ofpublish_engine_server_image.The existing build/test path which was approved previously is unchanged by this pr and can be seen working in this workflow https://app.circleci.com/pipelines/github/kurtosis-tech/kurtosis/9408/workflows/bb48e469-2ff7-433e-8da9-ad32620b0bbc.
Is this change user facing?
NO