fix: display the relevant number in the error message #1835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoporoli
approved these changes
Nov 21, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 21, 2023
🤖 I have created a release *beep* *boop* --- ## [0.85.34](0.85.33...0.85.34) (2023-11-21) ### Bug Fixes * display the relevant number in the error message ([#1835](#1835)) ([a8c24bc](a8c24bc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Tiny bug when running
kurtosis clean -a: if your APIC has more than one service running in it it will print an error, but print the number of services it found incorrectly:Why did I have more than 1 in this case? I'd added one directly via
kubectl exposeso the only bug here is the error display.Is this change user facing?
YES: only in the weeds of error message logging
References (if applicable):