fix: Rename jwtToken cookie #1876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adschwartz
reviewed
Dec 1, 2023
adschwartz
approved these changes
Dec 1, 2023
|
Fwiw cloud-frontend change has rolled out so this will work |
Dartoxian
force-pushed
the
bgazzard/rename-cookie
branch
from
e698efa
to
be0f8e2
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
🤖 I have created a release *beep* *boop* --- ## [0.85.42](0.85.41...0.85.42) (2023-12-05) ### Bug Fixes * Rename jwtToken cookie ([#1876](#1876)) ([3b13372](3b13372)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR renames the cookie used by the emui to
_kurtosis_jwt_token. This change must not be deployed before https://github.com/kurtosis-tech/kurtosis-cloud-frontend/pull/69.Is this change user facing?
YES
References (if applicable):