Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: persistent volumes work on multi node k8s clusters #1943

Merged
merged 29 commits into from Dec 15, 2023

Conversation

h4ck3rk3y
Copy link
Contributor

@h4ck3rk3y h4ck3rk3y commented Dec 13, 2023

feat: use storage-class in the kurtosis-config.yaml; users should make sure that they have the right storage class configured in their kurtosis-config.yaml

@h4ck3rk3y
Copy link
Contributor Author

h4ck3rk3y commented Dec 13, 2023

TODO

  • deletion

Copy link

cloudflare-pages bot commented Dec 13, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7dbeb77
Status: ✅  Deploy successful!
Preview URL: https://fc73be4c.kurtosis-docs.pages.dev
Branch Preview URL: https://gyani-persistent-volumes.kurtosis-docs.pages.dev

View logs

## Description:
Introduces the ability to have persistent directories of a given size
using `size`

## Is this change user facing?
YES
@h4ck3rk3y h4ck3rk3y marked this pull request as draft December 13, 2023 17:55
@h4ck3rk3y h4ck3rk3y marked this pull request as ready for review December 14, 2023 07:12
@h4ck3rk3y h4ck3rk3y removed the DO NOT MERGE DO NOT MERGE THIS PR label Dec 15, 2023
Copy link
Contributor

@leoporoli leoporoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with some comments. The most important is the one related to waiting for pv binding is it not necessary to know that the cluster provider creates the PV? or how Kurtosis detects that the cluster provider (DO, for instance) creates the PV?

@leoporoli
Copy link
Contributor

Note this enforces usage of storage-class. Is this a breaking change?

@h4ck3rk3y I think if users run kurtosis engine restart and it returns an error because they don't have the storage class defined it will be a breaking change, but if it's well described in the changelogs I think we could release it before the BCH date because the affectation is low, at least this is my perspective.

@h4ck3rk3y h4ck3rk3y added this pull request to the merge queue Dec 15, 2023
Merged via the queue into main with commit b2fd9f2 Dec 15, 2023
36 checks passed
@h4ck3rk3y h4ck3rk3y deleted the gyani/persistent-volumes branch December 15, 2023 14:21
github-merge-queue bot pushed a commit that referenced this pull request Dec 18, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.85.49](0.85.48...0.85.49)
(2023-12-18)


### Features

* add production mode to k8s
([#1963](#1963))
([b0e27e6](b0e27e6))
* persistent volumes work on multi node k8s clusters
([#1943](#1943))
([b2fd9f2](b2fd9f2))
* User service K8S ingresses for reverse proxy routing
([#1941](#1941))
([c37dd7f](c37dd7f))


### Bug Fixes

* adding remove logs aggregator container function when it already
exists ([#1974](#1974))
([5d74d16](5d74d16))
* Do not fail if the Traefik config dir path already exists
([#1966](#1966))
([4e6f7d7](4e6f7d7))
* ignore the current status of the service during a start/stop
([#1965](#1965))
([1c4863f](1c4863f))
* refactor the emui components to the shared package
([#1959](#1959))
([a406973](a406973))
* Set the user service K8S ingress labels so it can be found
([#1962](#1962))
([9cc5f77](9cc5f77))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Co-authored-by: leoporoli <leandroporoli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants