fix: small Emui QoL improvements #1944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adschwartz
approved these changes
Dec 13, 2023
Dartoxian
force-pushed
the
bgazzard/fix-polka
branch
from
f1d141f
to
05f017d
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 14, 2023
🤖 I have created a release *beep* *boop* --- ## [0.85.47](0.85.46...0.85.47) (2023-12-14) ### Features * Add CORS policy to REST API server ([#1924](#1924)) ([a934b1e](a934b1e)) * allow specifying size of persistent directories ([#1939](#1939)) ([5a997bc](5a997bc)) ### Bug Fixes * enclave name in error message ([#1942](#1942)) ([4754073](4754073)) * fix cloud link out markdown ([#1929](#1929)) ([846efb1](846efb1)) * small Emui QoL improvements ([#1944](#1944)) ([21b5ffd](21b5ffd)) * update startosis test ([#1945](#1945)) ([cc44ade](cc44ade)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
h4ck3rk3y
pushed a commit
that referenced
this pull request
Dec 15, 2023
## Description: This PR makes some small quality of life improvements identified whilst debugging the polka issue: * Strip `https://` from the start of github package urls * Handle bad arg types more gracefully (screenshot below) * Use unique keys in the DataTable component to stop react complaining.  ## Is this change user facing? YES ## References (if applicable): * https://sageroomworkspace.slack.com/archives/C060Z6HDYR3/p1702477312080589
h4ck3rk3y
pushed a commit
that referenced
this pull request
Dec 15, 2023
🤖 I have created a release *beep* *boop* --- ## [0.85.47](0.85.46...0.85.47) (2023-12-14) ### Features * Add CORS policy to REST API server ([#1924](#1924)) ([a934b1e](a934b1e)) * allow specifying size of persistent directories ([#1939](#1939)) ([5a997bc](5a997bc)) ### Bug Fixes * enclave name in error message ([#1942](#1942)) ([4754073](4754073)) * fix cloud link out markdown ([#1929](#1929)) ([846efb1](846efb1)) * small Emui QoL improvements ([#1944](#1944)) ([21b5ffd](21b5ffd)) * update startosis test ([#1945](#1945)) ([cc44ade](cc44ade)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR makes some small quality of life improvements identified whilst debugging the polka issue:
https://from the start of github package urlsIs this change user facing?
YES
References (if applicable):