Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: image build spec #1964

Merged
merged 44 commits into from Dec 19, 2023
Merged

feat: image build spec #1964

merged 44 commits into from Dec 19, 2023

Conversation

tedim52
Copy link
Contributor

@tedim52 tedim52 commented Dec 15, 2023 •
edited

Description:

This changes adds the ImageBuildSpec built in type that can be used to build images in Kurtosis packages.
eg.

def run(plan, args):
    plan.add_service(
        name="server",
        config=ServiceConfig(
            image=ImageBuildSpec(
                image_name="server",
                build_context_dir="./server",
            ),
        ....
        ))

Is this change user facing?

YES

@tedim52 tedim52 marked this pull request as draft December 15, 2023 05:52
@cloudflare-pages Cloudflare Pages
Copy link

cloudflare-pages bot commented Dec 19, 2023 •
edited

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 825ba6f
Status: ✅  Deploy successful!
Preview URL: https://269f4d1e.kurtosis-docs.pages.dev
Branch Preview URL: https://tedi-image-build-spec.kurtosis-docs.pages.dev

View logs

@tedim52 tedim52 marked this pull request as ready for review December 19, 2023 03:41
leoporoli
leoporoli approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@leoporoli leoporoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tedim52 tedim52 added this pull request to the merge queue Dec 19, 2023
Merged via the queue into main with commit 367d13b Dec 19, 2023
36 checks passed
@tedim52 tedim52 deleted the tedi/image-build-spec branch December 19, 2023 21:58
@kurtosisbot kurtosisbot mentioned this pull request Dec 19, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Dec 20, 2023
@kurtosisbot
chore(main): release 0.85.52 (#1988)
c89e92a 
🤖 I have created a release *beep* *boop*
---


##
[0.85.52](0.85.51...0.85.52)
(2023-12-20)


### Features

* image build spec
([#1964](#1964))
([367d13b](367d13b))


### Bug Fixes

* bring back old enclave continuity
([#1990](#1990))
([723c81d](723c81d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoporoli leoporoli leoporoli approved these changes

@adschwartz adschwartz Awaiting requested review from adschwartz

Assignees
No one assigned
Labels
user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tedim52 @leoporoli