fix: destroying the current reverse proxy if it can't be used to create a new one during the CreateReverseProxy process
#1991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lostbean
approved these changes
Dec 20, 2023
h4ck3rk3y
approved these changes
Dec 20, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 20, 2023
🤖 I have created a release *beep* *boop* --- ## [0.85.53](0.85.52...0.85.53) (2023-12-20) ### Bug Fixes * change restart policy to always ([#1996](#1996)) ([c41583d](c41583d)) * destroying the current reverse proxy if it can't be used to create a new one during the `CreateReverseProxy` process ([#1991](#1991)) ([82d1565](82d1565)) * nil pointer error found in the `kurtosis clean -a` cmd, adding remove reverse proxy container function when it already exists ([#1995](#1995)) ([64eff3e](64eff3e)) * websocket keep-alive ([#1993](#1993)) ([509c508](509c508)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
destroying the current reverse proxy if it can't be used to create a new one during the
CreateReverseProxyprocessIs this change user facing?
NO
References (if applicable):
should fix the error reported by Barnabas here