fix: Make the reverse proxy connect and disconnect to and from the enclave network idempotent #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentluce
changed the title
tedim52
reviewed
Jan 3, 2024
...engine-lib/lib/backend_impls/docker/object_attributes_provider/object_attributes_provider.go
Show resolved
Hide resolved
tedim52
reviewed
Jan 3, 2024
...ackend_impls/docker/docker_kurtosis_backend/reverse_proxy_functions/network_reverse_proxy.go
Show resolved
Hide resolved
tedim52
reviewed
Jan 3, 2024
...ackend_impls/docker/docker_kurtosis_backend/reverse_proxy_functions/network_reverse_proxy.go
Show resolved
Hide resolved
tedim52
reviewed
Jan 3, 2024
...ackend_impls/docker/docker_kurtosis_backend/reverse_proxy_functions/network_reverse_proxy.go
Show resolved
Hide resolved
tedim52
approved these changes
Jan 3, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 8, 2024
🤖 I have created a release *beep* *boop* --- ## [0.85.56](0.85.55...0.85.56) (2024-01-05) ### Features * docker compose integration [pt. 1] ([#2001](#2001)) ([385833d](385833d)) ### Bug Fixes * in api/golang go.mod use a fixed version of the new utils sub package ([#2022](#2022)) ([05099e5](05099e5)) * Make the reverse proxy connect and disconnect to and from the enclave network idempotent ([#2004](#2004)) ([3cc68eb](3cc68eb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR makes the reverse proxy network calls idempotent so the engine can be started when networking is already set up. This can happen when you restart the docker daemon.
In addition, this PR appends the engine UUID to the reverse proxy container name to make it unique across runs. This is an approach similar to the engine naming scheme which is cleaner and safer.
Is this change user facing?
NO
References (if applicable):
#2005