feat: docker compose integration pt. 2 #2043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedim52
commented
Jan 11, 2024
tedim52
force-pushed
the
tedi/compose-integration
branch
from
6a2aa42
to
14abeda
Compare
lostbean
approved these changes
Jan 12, 2024
core/server/api_container/server/docker_compose_transpiler/docker_compose_transpiler.go
Show resolved
Hide resolved
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 15, 2024
🤖 I have created a release *beep* *boop* --- ## [0.86.5](0.86.4...0.86.5) (2024-01-15) ### Features * docker compose integration pt. 2 ([#2043](#2043)) ([2a2793b](2a2793b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 22, 2024
## Description This PR contains various improvements (and hacks) to docker compose transpiler to improve it's coverage of docker composes, specifically in the `awesome-compose` repo. - support for per service `env_file` key - better path support, notably turn filepaths referencing upstream or home path to Persistent Directories - use container name as service name if set (required for hostname networking) - support for volumes mounting files (before only supported directories due to files artifact expansion limitations) - converts invalid service names to ones that are RFC 1035 other fixes for compose to enable more docker compose coverage: - allow uploading entire package contents into a files artifact - allow compressing empty directories ## Is this change user facing? NO ## References #2043 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Ben Gazzard <ben@dartoxia.com> Co-authored-by: Gyanendra Mishra <anomaly.the@gmail.com> Co-authored-by: kurtosisbot <89932784+kurtosisbot@users.noreply.github.com> Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Laurent Luce <laurentluce49@yahoo.com> Co-authored-by: leoporoli <leandroporoli@gmail.com> Co-authored-by: leovct <l009.vincent@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This feature allows users to run basic docker compose's with Kurtosis. Now, directories containing a
kurtosis.ymlOR adocker-compose.yamlare treated as starlark packages. If a compose package is detected,APICconverts the compose to Starlark, and executes the Starlark within enclaves.eg.
kurtosis run .kurtosis run github.com/awesome-compose/djangoIs this change user facing?
YES
References:
Part 1 (Docker Compose Transpiler) #2001