fix: emui enable exact package name searching #2052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adschwartz
approved these changes
Jan 16, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 17, 2024
🤖 I have created a release *beep* *boop* --- ## [0.86.7](0.86.6...0.86.7) (2024-01-16) ### Bug Fixes * emui enable exact package name searching ([#2052](#2052)) ([69c57ec](69c57ec)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 19, 2024
## Description: This fixes an issue reported by @adschwartz and @chunha-park where packages which use the catch all `args` arg, like the ethereum package show the following error:  This error is occuring because the `args` arg has no 'TopLevelType', so prior to #2052 the `args` field was not parsed as json/yaml when read. However in #2052 the default behaviour was modified to parse fields with an unknown type as json/yaml. This created this new bug, since the `args` field was no parsed twice. This fix removes the additional parsing in the 'submit' flow. ## Is this change user facing? YES ## References (if applicable): - https://sageroomworkspace.slack.com/archives/C060Z6HDYR3/p1705615425847449
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR implements exact package name searching in the EMUI. This allows indexing errors to be surfaced in the UI, for example:
exact-match.webm
This PR also fixes #2051 by treating arguments with no argtype (as is the case for the
argsargument) as aJSONargument. This behaviour for Form->kurtosis format is now consistent with the existing kurtosis format->Form transformer.Is this change user facing?
YES
References (if applicable):