fix: allow persistent directory to be reused across services #2123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is pretty interesting from a product perspective - makes the enclave behave more and more like a filesystem. |
tedim52
changed the title
tedim52
approved these changes
Feb 6, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
🤖 I have created a release *beep* *boop* --- ## [0.86.14](0.86.13...0.86.14) (2024-02-06) ### Bug Fixes * allow persistent directory to be reused across services ([#2123](#2123)) ([eb5bcb9](eb5bcb9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are workflows where people want to use prepopulated persistent volumes in different services. #2121 is an example of this workflow
This PR
Note in Kubernetes this will break for multi node clusters and this reuse of PVs will have to be in conjunction with node affinity selectors