feat: kurtosis run --non-blocking-tasks
#2153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedim52
changed the title
--non-blocking-tasks
leoporoli
reviewed
Feb 15, 2024
core/server/api_container/server/startosis_engine/kurtosis_instruction/tasks/tasks_shared.go
Show resolved
Hide resolved
leoporoli
approved these changes
Feb 15, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 16, 2024
🤖 I have created a release *beep* *boop* --- ## [0.86.25](0.86.24...0.86.25) (2024-02-16) ### Features * emui builder python nodes ([#2170](#2170)) ([26ad571](26ad571)) * kurtosis run `--non-blocking-tasks` ([#2153](#2153)) ([6c70247](6c70247)) ### Bug Fixes * allow for single quotes in run_python ([#2172](#2172)) ([4048368](4048368)), closes [#2171](#2171) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds a flag
--non-blocking-tasks. If set, task services fromrun_shandrun_pythonare not removed before continuing with execution. The effects is small over Docker, but this significantly reduces run times over k8s because of the overhead of removing a pod (up to 30s).For the
ethereum-packageover k8s with images cached, running with the flag goes from 4min to 1min. However, task services will have to be removed manually after execution or via akurtosis clean.Is this change user facing?
YES
References:
#2140