feat: support package nodes in enclave builder ui #2283

tedim52 · 2024-03-13T19:06:14Z

Description

THIS PR IS A COPY OF THIS PR: #2250

The frontend PR was initially made off the backend PR branch. I merged the backend PR branch to main. Then merged the frontend PR into the backend PR branch. Now merging into main again.

gitguardian · 2024-03-13T19:06:39Z

⚠️ GitGuardian has uncovered 39 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
9583343	Triggered	Generic Password	`8c7a419`	core/server/api_container/server/startosis_engine/plan_yaml_generator_test.go	View secret
9583343	Triggered	Generic Password	`323ac97`	core/server/api_container/server/startosis_engine/plan_yaml_generator_test.go	View secret
9583343	Triggered	Generic Password	`80ace33`	core/server/api_container/server/startosis_engine/plan.yml	View secret
9583343	Triggered	Generic Password	`908ad7d`	core/server/api_container/server/startosis_engine/plan_yaml_generator_test.go	View secret
9583343	Triggered	Generic Password	`ccc256b`	core/server/api_container/server/startosis_engine/plan.yml	View secret
9583343	Triggered	Generic Password	`458fd75`	core/server/api_container/server/startosis_engine/plan_yaml_generator_test.go	View secret
9583343	Triggered	Generic Password	`ccc256b`	core/server/api_container/server/startosis_engine/plan_yaml_generator_test.go	View secret
9583343	Triggered	Generic Password	`21e4ead`	core/server/api_container/server/startosis_engine/plan.yml	View secret
9583343	Triggered	Generic Password	`0544d1b`	core/server/api_container/server/startosis_engine/plan.yml	View secret
9583343	Triggered	Generic Password	`9109cac`	core/server/api_container/server/startosis_engine/plan_yaml_generator_test.go	View secret
9583343	Triggered	Generic Password	`21e4ead`	core/server/api_container/server/startosis_engine/plan.yml	View secret
9583343	Triggered	Generic Password	`8c7a419`	core/server/api_container/server/startosis_engine/plan_yaml_generator_test.go	View secret
9583343	Triggered	Generic Password	`679ed73`	core/server/api_container/server/startosis_engine/plan_yaml_generator_test.go	View secret
9583343	Triggered	Generic Password	`a4e7031`	core/server/api_container/server/startosis_engine/plan_yaml_generator_test.go	View secret
9583343	Triggered	Generic Password	`aef291e`	core/server/api_container/server/startosis_engine/plan.yml	View secret
9583343	Triggered	Generic Password	`aef291e`	core/server/api_container/server/startosis_engine/plan_yaml_generator_test.go	View secret
9583343	Triggered	Generic Password	`ae9f7ce`	core/server/api_container/server/startosis_engine/plan_yaml_generator_test.go	View secret
9583343	Triggered	Generic Password	`80ace33`	core/server/api_container/server/startosis_engine/plan.yml	View secret
9583343	Triggered	Generic Password	`21e4ead`	core/server/api_container/server/startosis_engine/plan_yaml_generator_test.go	View secret
9583343	Triggered	Generic Password	`a4e7031`	core/server/api_container/server/startosis_engine/plan_yaml_generator_test.go	View secret
9583343	Triggered	Generic Password	`9109cac`	core/server/api_container/server/startosis_engine/plan_yaml_generator_test.go	View secret
9583343	Triggered	Generic Password	`21e4ead`	core/server/api_container/server/startosis_engine/plan_yaml_generator_test.go	View secret
9583343	Triggered	Generic Password	`323ac97`	core/server/api_container/server/startosis_engine/plan.yml	View secret
9583343	Triggered	Generic Password	`03a7535`	core/server/api_container/server/startosis_engine/plan.yml	View secret
9583343	Triggered	Generic Password	`3998b57`	core/server/api_container/server/startosis_engine/plan.yml	View secret
9583343	Triggered	Generic Password	`3998b57`	core/server/api_container/server/startosis_engine/plan.yml	View secret
9583343	Triggered	Generic Password	`13a5cba`	core/server/api_container/server/startosis_engine/plan_yaml_generator_test.go	View secret
9583343	Triggered	Generic Password	`13a5cba`	core/server/api_container/server/startosis_engine/plan_yaml_generator_test.go	View secret
9583343	Triggered	Generic Password	`d190067`	core/server/api_container/server/startosis_engine/plan.yml	View secret
9583343	Triggered	Generic Password	`13a5cba`	core/server/api_container/server/startosis_engine/plan.yml	View secret
9583343	Triggered	Generic Password	`13a5cba`	core/server/api_container/server/startosis_engine/plan_yaml_generator_test.go	View secret
9583343	Triggered	Generic Password	`13a5cba`	core/server/api_container/server/startosis_engine/plan.yml	View secret
9583343	Triggered	Generic Password	`d190067`	core/server/api_container/server/startosis_engine/plan.yml	View secret
9583343	Triggered	Generic Password	`ec3cf48`	core/server/api_container/server/startosis_engine/startosis_interpreter_plan_yaml_test.go	View secret
9966505	Triggered	Generic Password	`ec3cf48`	core/server/api_container/server/startosis_engine/startosis_interpreter_plan_yaml_test.go	View secret
9966505	Triggered	Generic Password	`ec3cf48`	core/server/api_container/server/startosis_engine/startosis_interpreter_plan_yaml_test.go	View secret
9966505	Triggered	Generic Password	`f69701f`	core/server/api_container/server/startosis_engine/startosis_interpreter_plan_yaml_test.go	View secret
9966505	Triggered	Generic Password	`b254a49`	core/server/api_container/server/startosis_engine/startosis_interpreter_plan_yaml_test.go	View secret
9966505	Triggered	Generic Password	`b254a49`	core/server/api_container/server/startosis_engine/startosis_interpreter_plan_yaml_test.go	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

@tedim52

## Description: This PR adds package nodes to the enclave builder UI. It's based on the backend work added by @tedim52 in #2177. ### Demo This demo has two paths - the first one shows how a package can be added to the enclave builder, and used by a service defined in the builder as a dependency. The second one shows how two packages can be combined in the same enclave - allowing connectivity between them at runtime. https://github.com/kurtosis-tech/kurtosis/assets/4419574/64ed2b91-1565-49ed-841b-c655dd6b28f9 ## Is this change user facing? YES ## References (if applicable): - Discussion on slack. --------- Co-authored-by: Tedi Mitiku <tedi.m52@gmail.com>

🤖 I have created a release *beep* *boop* --- ## [0.88.6](0.88.5...0.88.6) (2024-03-13) ### Features * define `build_args` in `ImageBuildSpec` ([#2257](#2257)) ([9812375](9812375)) * generate plan yamls ([#2177](#2177)) ([2292010](2292010)) * port guessing based on port number for docker transpiler ([#2281](#2281)) ([5c98ce2](5c98ce2)) * support package nodes in enclave builder ui ([#2283](#2283)) ([7fa27ed](7fa27ed)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>

## Description THIS PR IS A COPY OF THIS PR: #2250 The frontend PR was initially made off the backend PR branch. I merged the backend PR branch to main. Then merged the frontend PR into the backend PR branch. Now merging into main again. --------- Co-authored-by: Ben Gazzard <ben@dartoxia.com>

🤖 I have created a release *beep* *boop* --- ## [0.88.6](0.88.5...0.88.6) (2024-03-13) ### Features * define `build_args` in `ImageBuildSpec` ([#2257](#2257)) ([9812375](9812375)) * generate plan yamls ([#2177](#2177)) ([2292010](806a13e)) * port guessing based on port number for docker transpiler ([#2281](#2281)) ([5c98ce2](e20fb32)) * support package nodes in enclave builder ui ([#2283](#2283)) ([7fa27ed](3c25691)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>

## Description THIS PR IS A COPY OF THIS PR: #2250 The frontend PR was initially made off the backend PR branch. I merged the backend PR branch to main. Then merged the frontend PR into the backend PR branch. Now merging into main again. --------- Co-authored-by: Ben Gazzard <ben@dartoxia.com>

🤖 I have created a release *beep* *boop* --- ## [0.88.6](0.88.5...0.88.6) (2024-03-13) ### Features * define `build_args` in `ImageBuildSpec` ([#2257](#2257)) ([9812375](9812375)) * generate plan yamls ([#2177](#2177)) ([2292010](e157686)) * port guessing based on port number for docker transpiler ([#2281](#2281)) ([5c98ce2](3a32230)) * support package nodes in enclave builder ui ([#2283](#2283)) ([7fa27ed](0b2395d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>

tedim52 added 30 commits February 15, 2024 15:43

setup plan yaml generator

400f08b

checkpoint

ffdf6cc

add scaffolding

d22b7d2

add get arguments to kurtosis instruction interface

46fae9d

adjust plan yaml generator to get service config

1b437e4

add postgres package test

f4b3152

start render templates impl

908ad7d

finish render templates impl

a4e7031

fix render templates impl

03a7535

impl upload files

aef291e

start impl run sh

458fd75

adjust task yaml def

9f5f442

impl run sh checkpoint

52f003c

finish run sh impl

eff877f

impl run python

32b53b1

commento out tests for now

ee35dda

impl store service

f8c6939

change order of name and uuid

5ecf11a

catch service config err

6146fc1

add plan yaml endpoint to protobuf

9daaabc

regenerate proto bindings

29b3f2c

implement plan yaml retrieval

27acec6

impl plan yaml endpoint in enclave mngr

247f6cc

fix protobuf

316f182

impl endpoints in gateway

4ab95ea

Merge branch 'main' into tedi/dryrun

fd8ac0c

fmt

8a67c71

tidy

1972b43

lint

5397fe6

Merge branch 'main' into tedi/dryrun

b7fa08b

tedim52 added 11 commits March 11, 2024 17:15

fix images

cdd9ceb

remove warnings

f9a4985

lint

aad10f9

Merge branch 'main' into tedi/dryrun

4a9343a

touch up

321ad2f

Merge branch 'main' into tedi/dryrun

97ddc8f

fix duplicate field

a6a13b3

Merge branch 'main' into tedi/dryrun

4cad9bb

address comments and fix merge conflicts

5a8a6f2

Merge branch 'main' into tedi/dryrun

3ca4954

refactor files artifacts expansion to file mount logic

6cfc873

tedim52 and others added 2 commits March 13, 2024 15:06

Merge branch 'main' into tedi/dryrun

159eee9

tedim52 changed the title ~~Tedi/dryrun~~ feat: support package nodes in enclave builder ui Mar 13, 2024

remove unused var

c9518c0

laurentluce self-requested a review March 13, 2024 20:37

laurentluce approved these changes Mar 13, 2024

View reviewed changes

tedim52 enabled auto-merge March 13, 2024 20:58

tedim52 added this pull request to the merge queue Mar 13, 2024

Merged via the queue into main with commit 7fa27ed Mar 13, 2024
51 of 52 checks passed

tedim52 deleted the tedi/dryrun branch March 13, 2024 21:14

kurtosisbot mentioned this pull request Mar 13, 2024

chore(main): release 0.88.6 #2278

Merged

tedim52 restored the tedi/dryrun branch March 13, 2024 21:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support package nodes in enclave builder ui #2283

feat: support package nodes in enclave builder ui #2283

tedim52 commented Mar 13, 2024 •

edited

gitguardian bot commented Mar 13, 2024 •

edited

feat: support package nodes in enclave builder ui #2283

feat: support package nodes in enclave builder ui #2283

Conversation

tedim52 commented Mar 13, 2024 • edited

Description

gitguardian bot commented Mar 13, 2024 • edited

⚠️ GitGuardian has uncovered 39 secrets following the scan of your pull request.

tedim52 commented Mar 13, 2024 •

edited

gitguardian bot commented Mar 13, 2024 •

edited