fix!: copy contents of directory instead of the directory if store is used for directories #2326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoporoli
approved these changes
Mar 25, 2024
|
Before this gets merged we have to have a PR ready to go for all major kurtosis packages, and all CI jobs have to be tested with this new version, as I expect it to break a lot of things! |
h4ck3rk3y
added
DO NOT MERGE
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 29, 2024
🤖 I have created a release *beep* *boop* --- ## [0.89.0](0.88.19...0.89.0) (2024-04-29) ### ⚠ BREAKING CHANGES * copy contents of directory instead of the directory if store is used for directories ([#2326](#2326)) ### Bug Fixes * copy contents of directory instead of the directory if store is used for directories ([#2326](#2326)) ([4c776be](4c776be)), closes [#2227](#2227) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2227