Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set service v0 #2372

Merged
merged 27 commits into from Apr 25, 2024
Merged

feat: set service v0 #2372

merged 27 commits into from Apr 25, 2024

Conversation

tedim52
Copy link
Contributor

@tedim52 tedim52 commented Apr 11, 2024

Description

Adds set_service instruction which can be used to override the service config of a service added earlier in the plan. This can be really useful for two cases:

  1. A user wants to set a specific image (or other config) for a service in a package but the package author has not made the image configurable. This can be done by appending set_service to the plan.
    ex.
postgres = import_module("github.com/kurtosis-tech/postgres-package/main.star")

def run(plan, args):
    postgres.run(plan)
    plan.set_service(name="postgres", config=ServiceConfig(image="postgres:bullseye"))
  1. A user wants to swap out the image (or other config) of a service running in an enclave. This can be done by appending set_service to the plan and enclave editing.
    ex.
    https://www.loom.com/share/f88d0f5555dd49b0aeabc55c5ed41d43

This instruction has some functionality missing such as overriding ports, env vars, and cmd/entrypoint as these require special handling of future references and handling consecutive set service instructions properly but functionality can be added iteratively in future PRs.

Is this change user facing?

YES

References:

#2057

@tedim52 tedim52 changed the title feat: update service feat: set service Apr 17, 2024
@tedim52 tedim52 requested a review from h4ck3rk3y April 23, 2024 13:56
Copy link

cloudflare-pages bot commented Apr 23, 2024

Deploying kurtosis with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3d91543
Status: ✅  Deploy successful!
Preview URL: https://9f8ac7b2.kurtosis-docs.pages.dev
Branch Preview URL: https://tedi-updateservice.kurtosis-docs.pages.dev

View logs

@tedim52 tedim52 requested a review from h4ck3rk3y April 25, 2024 06:26
@tedim52 tedim52 changed the title feat: set service feat: set service v0 Apr 25, 2024
@tedim52 tedim52 added this pull request to the merge queue Apr 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 25, 2024
@tedim52 tedim52 added this pull request to the merge queue Apr 25, 2024
Merged via the queue into main with commit 7056164 Apr 25, 2024
53 checks passed
@tedim52 tedim52 deleted the tedi/updateservice branch April 25, 2024 19:45
github-merge-queue bot pushed a commit that referenced this pull request Apr 27, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.88.19](0.88.18...0.88.19)
(2024-04-25)


### Features

* adding the enclave-db inside the enclave's volume
([#2399](#2399))
([75805ef](75805ef))
* set service v0
([#2372](#2372))
([7056164](7056164))


### Bug Fixes

* typo in clean -a docs
([#2402](#2402))
([136ec4c](136ec4c))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this pull request Apr 30, 2024
## Description
Adds UI button for setting service image using `set_service`
instruction.

![Screen Shot 2024-04-26 at 2 01 06
PM](https://github.com/kurtosis-tech/kurtosis/assets/46531991/8709bdc9-da24-412e-b14c-e366e2630c2c)

https://www.loom.com/share/c6e87488214047c782bbffb1d3fa0bb5

## Is this change user facing?
YES

## References
#2372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants