Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable image build spec for tasks #2374

Merged
merged 5 commits into from Apr 17, 2024
Merged

feat: enable image build spec for tasks #2374

merged 5 commits into from Apr 17, 2024

Conversation

tedim52
Copy link
Contributor

@tedim52 tedim52 commented Apr 11, 2024

Description

ex.

def run(plan, args):
    result = plan.run_sh(
        run="echo ${SOME}",
        # build image containing openssl, gh cli, python, and bash, etc.
        image=ImageBuildSpec(
            build_context_dir="./",
            image_name="taskimg",
        ),
        env_vars={
            "SOME": "THING",
        }
    )
    plan.print(result)

Is this change user facing?

YES

References:

#2224

@tedim52 tedim52 requested a review from h4ck3rk3y April 17, 2024 13:46
@tedim52 tedim52 changed the title feat: enable image build spec for tasks feat: enable image build spec for run_sh Apr 17, 2024
@tedim52 tedim52 changed the title feat: enable image build spec for run_sh feat: enable image build spec for tasks Apr 17, 2024
@tedim52 tedim52 enabled auto-merge April 17, 2024 14:20
@tedim52 tedim52 added this pull request to the merge queue Apr 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 17, 2024
@tedim52 tedim52 added this pull request to the merge queue Apr 17, 2024
Merged via the queue into main with commit 3d5e6ec Apr 17, 2024
52 checks passed
@tedim52 tedim52 deleted the tedi/runshimg branch April 17, 2024 17:24
github-merge-queue bot pushed a commit that referenced this pull request Apr 22, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.88.18](0.88.17...0.88.18)
(2024-04-22)


### Features

* add and check port aliasing
([#2373](#2373))
([136f1e7](136f1e7))
* allow to set an alias and view them
([#2385](#2385))
([97e5c7d](97e5c7d))
* enable image build spec for tasks
([#2374](#2374))
([3d5e6ec](3d5e6ec))
* enable setting git token per package run
([#2355](#2355))
([4eaae9f](4eaae9f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants