fix: Fix error propagation in context switch #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbouv
force-pushed
the
gbouv/fix-error-propagation
branch
from
28ecbe0
to
3c382ea
Compare
adschwartz
approved these changes
May 31, 2023
victorcolombo
pushed a commit
that referenced
this pull request
Jun 8, 2023
🤖 I have created a release *beep* *boop* --- ## [0.77.2](0.77.1...0.77.2) (2023-06-08) ### Features * added min resource constraint for kubernetes ([#687](#687)) ([0aadb91](0aadb91)) * Label issue based on severity ([#662](#662)) ([13b51c6](13b51c6)) ### Bug Fixes * Auto-restart engine when cluster is updated ([#661](#661)) ([479b9f4](479b9f4)) * display service name in exec ([#682](#682)) ([6faafea](6faafea)) * Fix error propagation in context switch ([#658](#658)) ([a7c9bd1](a7c9bd1)) * Fix typo in the configuration path of the issue labeler workflow ([#667](#667)) ([ec6c8e8](ec6c8e8)) * Fix user service logs when backend is kubernetes ([#678](#678)) ([099d046](099d046)) * fixed the error we see while running the package(s) in dry-mode ([#679](#679)) ([af5138c](af5138c)) * Kurtosis shell exec panics if stdin is not terminal ([#686](#686)) ([5fad486](5fad486)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
stacktrace.propagatewas using the wrong error in context switch command. Fixing it so that if an error occurs during engine restart, kurtosis does not panic and log the nice error messageIs this change user facing?
NO