Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix TestStarlarkRemotePackage E2E test to reflect new quickstart #773

Merged
merged 2 commits into from
Jun 26, 2023

Conversation

victorcolombo
Copy link
Contributor

@victorcolombo victorcolombo commented Jun 26, 2023

Description:

TestStarlarkRemotePackage is failing with message

--- FAIL: TestStartosisSubpackageTestSuite (38.49s)
    --- FAIL: TestStartosisSubpackageTestSuite/TestStarlarkRemotePackage (11.18s)
        startosis_remote_subpackage_test.go:31: 
            	Error Trace:	/home/circleci/project/internal_testsuites/golang/testsuite/startosis_subpackage_test/startosis_remote_subpackage_test.go:31
            	Error:      	Not equal: 
            	            	expected: 22
            	            	actual  : 4
            	Test:       	TestStartosisSubpackageTestSuite/TestStarlarkRemotePackage

This is due to our recent change to awesome-kurtosis/quickstart package

Link: https://app.circleci.com/pipelines/github/kurtosis-tech/kurtosis/4176/workflows/7d44b594-7005-4736-883f-5fe2b40aff75/jobs/52308

Is this change user facing?

NO

References (if applicable):

@victorcolombo victorcolombo marked this pull request as ready for review June 26, 2023 14:45
@victorcolombo victorcolombo enabled auto-merge (squash) June 26, 2023 14:49
@victorcolombo victorcolombo merged commit e4dd53f into main Jun 26, 2023
27 checks passed
@victorcolombo victorcolombo deleted the vcolombo/fix-e2e branch June 26, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants