Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add minimal support for feature flags in APIC #775

Merged
merged 4 commits into from Jun 27, 2023
Merged

Conversation

gbouv
Copy link
Contributor

@gbouv gbouv commented Jun 26, 2023

Description:

This adds an --experimental flags to kurtosis run command to optionally turn on experimental features when running a Starlark package.

Is this change user facing?

YES

References (if applicable):

@gbouv gbouv force-pushed the gbouv/feature-flags branch 3 times, most recently from dc5ecad to 1737eaf Compare June 26, 2023 16:56
@cloudflare-pages
Copy link

cloudflare-pages bot commented Jun 26, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0fa3e42
Status: ✅  Deploy successful!
Preview URL: https://bbf2a834.kurtosis-docs.pages.dev
Branch Preview URL: https://gbouv-feature-flags.kurtosis-docs.pages.dev

View logs

Copy link
Contributor

@h4ck3rk3y h4ck3rk3y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Have a question around UX somewhere but looks alright 😀

cli/cli/commands/run/run.go Show resolved Hide resolved
cli/cli/commands/service/add/add.go Show resolved Hide resolved
docs/docs/cli-reference/run-starlark.md Show resolved Hide resolved
@gbouv gbouv enabled auto-merge (squash) June 27, 2023 13:04
@gbouv gbouv merged commit 0858f56 into main Jun 27, 2023
28 checks passed
@gbouv gbouv deleted the gbouv/feature-flags branch June 27, 2023 13:29
Peeeekay pushed a commit that referenced this pull request Jun 27, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.80.3](0.80.2...0.80.3)
(2023-06-27)


### Features

* Add minimal support for feature flags in APIC
([#775](#775))
([0858f56](0858f56))
* added port print functionality in cli for users to quickly check how
to access port.
([#778](#778))
([477510b](477510b))
* Implement idempotent run v0
([#769](#769))
([23b121f](23b121f))
* Stop and start service support in the CLI
([#767](#767))
([cd4ca05](cd4ca05)),
closes [#705](#705)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants