New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add minimal support for feature flags in APIC #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbouv
force-pushed
the
gbouv/feature-flags
branch
3 times, most recently
from
June 26, 2023 16:56
dc5ecad
to
1737eaf
Compare
Deploying with Cloudflare Pages
|
gbouv
force-pushed
the
gbouv/feature-flags
branch
from
June 26, 2023 17:15
1737eaf
to
c8f5729
Compare
gbouv
force-pushed
the
gbouv/feature-flags
branch
from
June 26, 2023 17:32
c8f5729
to
eb9693f
Compare
h4ck3rk3y
approved these changes
Jun 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Have a question around UX somewhere but looks alright 😀
Peeeekay
pushed a commit
that referenced
this pull request
Jun 27, 2023
🤖 I have created a release *beep* *boop* --- ## [0.80.3](0.80.2...0.80.3) (2023-06-27) ### Features * Add minimal support for feature flags in APIC ([#775](#775)) ([0858f56](0858f56)) * added port print functionality in cli for users to quickly check how to access port. ([#778](#778)) ([477510b](477510b)) * Implement idempotent run v0 ([#769](#769)) ([23b121f](23b121f)) * Stop and start service support in the CLI ([#767](#767)) ([cd4ca05](cd4ca05)), closes [#705](#705) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This adds an
--experimental
flags tokurtosis run
command to optionally turn on experimental features when running a Starlark package.Is this change user facing?
YES
References (if applicable):