New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: exposing kurtosis frontend v0 #833

Merged

Peeeekay merged 8 commits into main from pk/add_kurtosis_frontend

Jul 11, 2023

Contributor

Peeeekay commented Jul 6, 2023 •

edited

This PR just exposes the current to the user:

I have frontend directory in engine/fronted/...
the build artifacts generated by the frontend using npm build are stored in engine/server/engine/dist
these are copied over to engine dockerfile, and are exposed on port 9711..

The frontend build artifacts step is manual at the moment; will include this in build process in upcoming PR(s).
This is only working with docker backend at the moment; will make it work with k8s in upcoming PRs .

This is not backward compatible; that is frontend would not work with enclaves created before 0.80.8

Peeeekay force-pushed the pk/add_kurtosis_frontend branch from a3fd9bc to f3d1801 Compare

July 7, 2023 14:16

Peeeekay requested review from laurentluce, leoporoli and adschwartz

July 10, 2023 18:53

Peeeekay marked this pull request as ready for review

July 10, 2023 18:54

Peeeekay requested review from gbouv and removed request for laurentluce

July 10, 2023 18:54

adschwartz reviewed

View reviewed changes

engine/server/webapp/index.html Outdated Show resolved Hide resolved

Contributor

adschwartz commented Jul 10, 2023

is there a reason you chose javascript over typescript? I'd think we would prefer ts unless there's a strong reason why not?

Contributor Author

Peeeekay commented Jul 11, 2023

is there a reason you chose javascript over typescript? I'd think we would prefer ts unless there's a strong reason why not?

The frontend code is pretty simple, and adding typescript will be just an overkill imo. I would def. need to refactor some of the js code to make it more maintainable at that time, I can use typescript.
For initial versions, I believe javascript is fine as in my experience typescript is very good for backend but for most frontends ( generally aren't super complex, mostly async requests and state management for those cases, javascript works well.

Peeeekay requested a review from adschwartz

July 11, 2023 18:21

leoporoli reviewed

View reviewed changes

...ngine-lib/lib/backend_impls/docker/docker_kurtosis_backend/engine_functions/create_engine.go Show resolved Hide resolved

leoporoli reviewed

View reviewed changes

...ngine-lib/lib/backend_impls/docker/docker_kurtosis_backend/engine_functions/create_engine.go Outdated Show resolved Hide resolved

leoporoli reviewed

View reviewed changes

...ngine-lib/lib/backend_impls/docker/docker_kurtosis_backend/engine_functions/create_engine.go Outdated Show resolved Hide resolved

leoporoli reviewed

View reviewed changes

...ngine-lib/lib/backend_impls/docker/docker_kurtosis_backend/engine_functions/create_engine.go Show resolved Hide resolved

leoporoli reviewed

View reviewed changes

...ngine-lib/lib/backend_impls/docker/docker_kurtosis_backend/engine_functions/create_engine.go Outdated Show resolved Hide resolved

leoporoli reviewed

View reviewed changes

...ngine-lib/lib/backend_impls/docker/docker_kurtosis_backend/engine_functions/create_engine.go Show resolved Hide resolved

leoporoli reviewed

View reviewed changes

engine/frontend/package.json Show resolved Hide resolved

leoporoli reviewed

View reviewed changes

engine/frontend/public/index.html Outdated Show resolved Hide resolved

leoporoli reviewed

View reviewed changes

engine/frontend/public/index.html Outdated Show resolved Hide resolved

leoporoli reviewed

View reviewed changes

engine/frontend/public/index.html Outdated Show resolved Hide resolved

leoporoli reviewed

View reviewed changes

engine/frontend/src/App.css Show resolved Hide resolved

leoporoli reviewed

View reviewed changes

engine/frontend/src/App.js Show resolved Hide resolved

leoporoli reviewed

View reviewed changes

engine/frontend/src/App.test.js Show resolved Hide resolved

leoporoli reviewed

View reviewed changes

engine/server/engine/main.go Outdated Show resolved Hide resolved

leoporoli reviewed

View reviewed changes

engine/server/engine/main.go Show resolved Hide resolved

leoporoli reviewed

View reviewed changes

engine/server/engine/main.go Show resolved Hide resolved

leoporoli reviewed

View reviewed changes

engine/server/engine/main.go Show resolved Hide resolved

leoporoli reviewed

View reviewed changes

engine/frontend/src/components/LeftView.js Show resolved Hide resolved

leoporoli reviewed

View reviewed changes

engine/frontend/src/components/LogView.js Show resolved Hide resolved

leoporoli reviewed

View reviewed changes

engine/frontend/src/components/Services.js Show resolved Hide resolved

leoporoli reviewed

View reviewed changes

engine/frontend/src/components/Services.js Show resolved Hide resolved

leoporoli approved these changes

View reviewed changes

Peeeekay added 8 commits

July 11, 2023 17:48


          feat: added frontend

3276bf0


          made updates

62b18f0


          updated minimal-grpc-server version

7f82e38


          renamed dist to webapp so that it is not ignored for now

1e64eb0


          replaced grpc insecure to fix linter issue

43afce9


          remvoed react-app references

68a7aa9


          removed unneccary files

c47aed0


          addressed comments

a1467e9

Peeeekay force-pushed the pk/add_kurtosis_frontend branch from ceebb9e to a1467e9 Compare

July 11, 2023 21:49

Peeeekay merged commit 110e910 into main

29 checks passed

Peeeekay deleted the pk/add_kurtosis_frontend branch

July 11, 2023 22:07

kurtosisbot mentioned this pull request

chore(main): release 0.80.8 #822

Merged

Peeeekay pushed a commit that referenced this pull request


          chore(main): release 0.80.8 (#822)

229fe70

🤖 I have created a release *beep* *boop*
---


##
[0.80.8](0.80.7...0.80.8)
(2023-07-11)


### Features

* auto assign docs issue to karla
([#834](#834))
([7d0a245](7d0a245))
* exposing kurtosis frontend v0
([#833](#833))
([110e910](110e910))
* Make Run also accept argument other than args dict
([#859](#859))
([9fce411](9fce411))


### Bug Fixes

* fixed the output for port print
([#816](#816))
([ede32e7](ede32e7))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>

mieubrisse restored the pk/add_kurtosis_frontend branch

July 14, 2023 20:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment