New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add kurtosis cloud load to CLI
#882
Conversation
# Conflicts: # api/golang/go.mod # api/golang/go.sum
# Conflicts: # cli/cli/commands/kurtosis_context/context_switch/switch.go # cli/cli/kurtosis_config/resolved_config/kurtosis_cluster_config.go
Note, the GitGuardian complaint about an API key being found can be ignored. It was a test key that's burned and no api keys are in the source code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general, but I think we don't need to declare a V3 for the config object and handle the migration logic. The change to the config you're making is backward compatible.
cli/cli/kurtosis_config/overrides_objects/v3/kurtosis_config_v3.go
Outdated
Show resolved
Hide resolved
# Conflicts: # go.work.sum
add kurtosis cloud load to CLI
kurtosis cloud load to CLI
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
7296163 | Generic High Entropy Secret | a5a0db9 | cli/cli/commands/cloud/load/load.go | View secret |
7296163 | Generic High Entropy Secret | 38ad7b2 | cli/cli/commands/cloud/load/load.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
# Conflicts: # cli/cli/go.mod # cli/cli/go.sum
🤖 I have created a release *beep* *boop* --- ## [0.80.20](0.80.19...0.80.20) (2023-07-27) ### Features * add `kurtosis cloud load to CLI` ([#882](#882)) ([b2db8c9](b2db8c9)) * ask user for email on first run of Kurtosis ([#1001](#1001)) ([0f33b5b](0f33b5b)) * Start engine remotely with remote backend config when the context is remote ([#963](#963)) ([6816d1f](6816d1f)) * validate min cpu & min memory are well under whats available ([#988](#988)) ([768e95d](768e95d)) ### Bug Fixes * Normalize destroy enclave in all tests ([#976](#976)) ([20b635a](20b635a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Description:
In this PR we are adding the
kurtosis cloud load <instance_id>
option that enables the user to load the config from the cloud and automatically switch the context.To use the command the user must export an API key to the env var:
KURTOSIS_CLOUD_API_KEY
Is this change user facing?
YES
References (if applicable):