Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add file artifact inspect API do APIC #885

Merged
merged 10 commits into from Jul 17, 2023
Merged

feat: Add file artifact inspect API do APIC #885

merged 10 commits into from Jul 17, 2023

Conversation

victorcolombo
Copy link
Contributor

Description:

Screenshot 2023-07-13 at 12 19 37

Is this change user facing?

YES/NO

References (if applicable):

@victorcolombo victorcolombo mentioned this pull request Jul 14, 2023
Merged
Peeeekay
Peeeekay approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@Peeeekay Peeeekay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good; some minor comments.

api/golang/core/lib/enclaves/enclave_context.go Show resolved Hide resolved
api/protobuf/core/api_container_service.proto Show resolved Hide resolved
core/server/api_container/server/api_container_service.go Outdated Show resolved Hide resolved
core/server/api_container/server/api_container_service.go Show resolved Hide resolved
core/server/api_container/server/api_container_service.go Outdated Show resolved Hide resolved
@victorcolombo victorcolombo enabled auto-merge (squash) July 17, 2023 18:30
@victorcolombo victorcolombo merged commit 7ad8155 into main Jul 17, 2023
28 of 29 checks passed
@victorcolombo victorcolombo deleted the vcolombo/files-inspect-api branch July 17, 2023 18:48
@kurtosisbot kurtosisbot mentioned this pull request Jul 17, 2023
Merged
victorcolombo added a commit that referenced this pull request Jul 18, 2023
@victorcolombo
feat: Add file inspect command to the CLI (#905)
bb36a46 
## Description:
<!-- Describe this change, how it works, and the motivation behind it.
-->
Depends on #885

![Screenshot 2023-07-14 at 17 24
06](https://github.com/kurtosis-tech/kurtosis/assets/1737857/9edd897a-c173-47ed-b3b7-efd195567848)

## Is this change user facing?
YES
<!-- If yes, please add the "user facing" label to the PR -->
<!-- If yes, don't forget to include docs changes where relevant -->

## References (if applicable):
<!-- Add relevant Github Issues, Discord threads, or other helpful
information. -->
victorcolombo pushed a commit that referenced this pull request Jul 18, 2023
@kurtosisbot
chore(main): release 0.80.11 (#923)
1896d5d 
🤖 I have created a release *beep* *boop*
---


##
[0.80.11](0.80.10...0.80.11)
(2023-07-18)


### Features

* Add file artifact inspect API do APIC
([#885](#885))
([7ad8155](7ad8155))
* Add file inspect command to the CLI
([#905](#905))
([bb36a46](bb36a46))
* added run python
([#913](#913))
([365f5cf](365f5cf))
* upload files support relative locators
([#930](#930))
([8d60968](8d60968))


### Bug Fixes

* make service labels more restrictive
([#929](#929))
([a8fb599](a8fb599)),
closes [#928](#928)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Peeeekay Peeeekay Peeeekay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@victorcolombo @Peeeekay